Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pull-down-refresh): update api #479

Merged
merged 11 commits into from
Oct 9, 2024
Merged

refactor(pull-down-refresh): update api #479

merged 11 commits into from
Oct 9, 2024

Conversation

novlan1
Copy link
Contributor

@novlan1 novlan1 commented Aug 21, 2024 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #406

💡 需求背景和解决方案

📝 更新日志

  • feat(PullDownRefresh): maxBarHeight 与 loadingBarHeight 属性扩展支持 string 类型，并新增 onRefresh、onScrolltolower 和 onTimeout 等属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 21, 2024 •
edited
Loading

完成

HaixingOoO
HaixingOoO reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example文件下的例子都改成tsx来写

@novlan1 novlan1 closed this Sep 4, 2024
@novlan1 novlan1 reopened this Sep 4, 2024
@novlan1
Copy link
Contributor Author

novlan1 commented Sep 4, 2024

example文件下的例子都改成tsx来写
@HaixingOoO done

@HaixingOoO
Copy link
Collaborator

@anlyyao review！！！

@anlyyao anlyyao merged commit d2ab974 into Tencent:develop Oct 9, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
anlyyao pushed a commit that referenced this pull request Nov 8, 2024
@novlan1 @anlyyao
refactor(pull-down-refresh): update api (#479)
2e94e12 
* refactor(pull-down-refresh): update api

* chore(pull-down-refresh): update docs

* feat(pull-down-refresh): add style props

* feat(pull-down-refresh): update pull-down

* refactor(pull-down-refresh): use unit tools of utils

* chore: update snapshot

* refactor: use StylesProps

* refactor(pull-down-refresh): remove @react-spring

* test(pull-down-refresh): update test snapshot

* refactor(pull-down-refresh): useMemo in trackStyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaixingOoO HaixingOoO HaixingOoO left review comments

@anlyyao anlyyao anlyyao approved these changes

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

@jarmywang jarmywang Awaiting requested review from jarmywang jarmywang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

【PullDownRefresh组件升级】任务单
3 participants
@novlan1 @HaixingOoO @anlyyao