Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TKSS-452: Tests should not depend on provider-internal classes #460

Merged
merged 1 commit into from
Oct 13, 2023
Merged

TKSS-452: Tests should not depend on provider-internal classes #460

merged 1 commit into from
Oct 13, 2023

Conversation

johnshajiang
Copy link
Collaborator

Generally, the applications, including tests, should not use provider-internal classes, say SM2PrivateKey and SM2PublicKey.
Instead, they should use only JDK public APIs, say SM2PrivateKeySpec and SM2PublicKeySpec.

This PR will resolves #452.

@johnshajiang johnshajiang added the testbug Something isn't working on tests label Oct 13, 2023
@johnshajiang johnshajiang self-assigned this Oct 13, 2023
@johnshajiang johnshajiang merged commit 8204667 into Tencent:master Oct 13, 2023
7 checks passed
@johnshajiang johnshajiang deleted the TKSS-452 branch October 13, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnshajiang johnshajiang

Labels
testbug Something isn't working on tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests should not depend on provider-internal classes
1 participant
@johnshajiang