Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): fix network debug information for ios in chrome devtool #4112

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Cyunong
Copy link
Contributor

@Cyunong Cyunong commented Nov 6, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the size: xs Denotes a PR that changes 0-9 lines label Nov 6, 2024
Copy link

hippy-service bot commented Nov 6, 2024

Hi, @Cyunong. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

Copy link

hippy-service bot commented Nov 6, 2024

After a quick scan, I have approved workflow to run.

🏷️ New commits in this PR would not be tested automatically until this pull request is reviewed by our collaborators.
🏷️ No need to worry about the status of merge_guard and [gh] pull request merge guard / merge_guard (pull_request_target) checks, once this pull request is met merge requirements, it will be automatically converted to successful status.

@github-actions github-actions bot added size: s Denotes a PR that changes 10-99 lines and removed size: xs Denotes a PR that changes 0-9 lines labels Nov 6, 2024
Copy link

hippy-service bot commented Nov 6, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 6, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) November 6, 2024 07:17
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 6, 2024
@wwwcg wwwcg disabled auto-merge November 6, 2024 07:40
@wwwcg wwwcg merged commit 20754ad into Tencent:main Nov 6, 2024
31 of 34 checks passed
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: ios size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants