Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(docs): add six key point #3824

Merged
merged 2 commits into from
Apr 12, 2024
Merged

refactor(docs): add six key point #3824

merged 2 commits into from
Apr 12, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from zealotchen0 as a code owner April 12, 2024 02:41
@github-actions github-actions bot added doc: pages size: s Denotes a PR that changes 10-99 lines labels Apr 12, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Apr 12, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Apr 12, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Apr 12, 2024
@siguangli siguangli enabled auto-merge (squash) April 12, 2024 02:43
@hippy-actions hippy-actions bot disabled auto-merge April 12, 2024 02:44
@hippy-actions hippy-actions bot enabled auto-merge (rebase) April 12, 2024 02:44
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Apr 12, 2024
@hippy-actions hippy-actions bot merged commit 53e2c35 into Tencent:main Apr 12, 2024
31 of 34 checks passed
@siguangli siguangli deleted the fix/six_key_point branch April 12, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zealotchen0 zealotchen0 zealotchen0 approved these changes

Assignees
No one assigned
Labels
doc: pages size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siguangli @zealotchen0 @siguangli2018