Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vue3): delete source prop for img #3760

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix(vue3): delete source prop for img #3760

merged 2 commits into from
Feb 28, 2024

Conversation

zealotchen0
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 27, 2024

Hi, @zealotchen0. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added driver: js size: s Denotes a PR that changes 10-99 lines labels Feb 27, 2024
gguoyu
gguoyu approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@gguoyu gguoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 28, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 28, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) February 28, 2024 02:51
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 28, 2024
@zealotchen0 zealotchen0 merged commit 20f3e66 into Tencent:main Feb 28, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguoyu gguoyu gguoyu approved these changes

Assignees
No one assigned
Labels
driver: js size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zealotchen0 @gguoyu @open-hippy