Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fix premature text truncation #3609

Merged
merged 2 commits into from
Feb 27, 2024
Merged

fix(android): fix premature text truncation #3609

merged 2 commits into from
Feb 27, 2024

Conversation

iPel
Copy link
Collaborator

@iPel iPel commented Nov 15, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@iPel iPel requested a review from siguangli as a code owner November 15, 2023 14:30
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 15, 2023

Hi, @iPel. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added the size: m Denotes a PR that changes 100-499 lines label Nov 15, 2023
@iPel iPel added the consistency consistency between android and ios label Nov 28, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 27, 2024

Pay attention 🛎️ !!
There has been no activity on this PR for 2 months, so I will label it stalled.
It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

@hippy-service hippy-service bot added the stale: 60d No interaction in the last 60 days label Jan 27, 2024
siguangli
siguangli previously approved these changes Feb 27, 2024
View reviewed changes
@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 27, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 27, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) February 27, 2024 12:15
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 27, 2024
auto-merge was automatically disabled February 27, 2024 12:18

Rebase failed

@siguangli siguangli added the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 27, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) February 27, 2024 12:20
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 27, 2024
auto-merge was automatically disabled February 27, 2024 12:20

Rebase failed

@siguangli siguangli added the action(squash-merge) Squash and merge action label Feb 27, 2024
@hippy-actions hippy-actions bot enabled auto-merge (squash) February 27, 2024 12:24
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Feb 27, 2024
@hippy-actions hippy-actions bot merged commit 89ce3d7 into Tencent:main Feb 27, 2024
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
consistency consistency between android and ios renderer: native size: m Denotes a PR that changes 100-499 lines stale: 60d No interaction in the last 60 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iPel @siguangli