Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(renderer): invalid #3162

Closed
wants to merge 3 commits into from
Closed

fix(renderer): invalid #3162

wants to merge 3 commits into from

Conversation

etkmao
Copy link
Collaborator

@etkmao etkmao commented Apr 24, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@etkmao etkmao requested a review from siguangli as a code owner April 24, 2023 05:28
@github-actions github-actions bot added renderer: tdf size: xs Denotes a PR that changes 0-9 lines labels Apr 24, 2023
@hippy-service
Copy link

hippy-service bot commented Apr 24, 2023

Hi, @etkmao. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@etkmao etkmao changed the title Bugfix/tdf20230420 fix(renderer): tdfrender compile fix Apr 24, 2023
@etkmao etkmao force-pushed the bugfix/tdf20230420 branch from 8a9356b to 687c56a Compare April 24, 2023 06:15
@github-actions github-actions bot added doc: example framework: android size: s Denotes a PR that changes 10-99 lines and removed size: xs Denotes a PR that changes 0-9 lines labels Apr 24, 2023
@etkmao etkmao changed the title fix(renderer): tdfrender compile fix fix(renderer): invalid Apr 24, 2023
@hippy-service
Copy link

hippy-service bot commented May 12, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@hippy-service
Copy link

hippy-service bot commented Jul 11, 2023

Pay attention 🛎️ !!
There has been no activity on this PR for 2 months, so I will label it stalled.
It will be automatically closed in 30 days if no more activity. Feel free to leave a comment if you have any questions.

@hippy-service hippy-service bot added the stale: 60d No interaction in the last 60 days label Jul 11, 2023
@hippy-service
Copy link

hippy-service bot commented Sep 9, 2023

Sorry, closing this PR because it has stalled for over 4 months.
Feel free to reopen if this PR is still relevant, or to ping the collaborator if you have any questions.

@hippy-service hippy-service bot added the stale: closed Closed due to stale label Sep 9, 2023
@hippy-service hippy-service bot closed this Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siguangli siguangli siguangli approved these changes

Assignees
No one assigned
Labels
doc: example framework: android renderer: tdf size: s Denotes a PR that changes 10-99 lines stale: closed Closed due to stale stale: 60d No interaction in the last 60 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etkmao @siguangli