fix(perf): support dom time for performance api

Tencent · Aug 4, 2023 · f35f899 · f35f899
1 parent d7b7ec4
commit f35f899
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 1 deletion.
diff --git a/dom/include/dom/dom_manager.h b/dom/include/dom/dom_manager.h
@@ -131,6 +131,11 @@ class DomManager : public std::enable_shared_from_this<DomManager> {
   static byte_string GetSnapShot(const std::shared_ptr<RootNode>& root_node);
   bool SetSnapShot(const std::shared_ptr<RootNode>& root_node, const byte_string& buffer);
 
+  void RecordDomStartTimePoint();
+  void RecordDomEndTimePoint();
+  inline auto GetDomStartTimePoint() { return dom_start_time_point_; }
+  inline auto GetDomEndTimePoint() { return dom_end_time_point_; }
+
  private:
   friend class DomNode;
 
@@ -140,6 +145,9 @@ class DomManager : public std::enable_shared_from_this<DomManager> {
   std::unordered_map<uint32_t, std::shared_ptr<BaseTimer>> timer_map_;
   std::shared_ptr<TaskRunner> task_runner_;
   std::shared_ptr<Worker> worker_;
+
+  footstone::TimePoint dom_start_time_point_;
+  footstone::TimePoint dom_end_time_point_;
 };
 
 }  // namespace dom

diff --git a/dom/src/dom/dom_manager.cc b/dom/src/dom/dom_manager.cc
@@ -262,5 +262,17 @@ bool DomManager::SetSnapShot(const std::shared_ptr<RootNode>& root_node, const b
   return true;
 }
 
+void DomManager::RecordDomStartTimePoint() {
+  if (dom_start_time_point_.ToEpochDelta() == TimeDelta::Zero()) {
+    dom_start_time_point_ = footstone::TimePoint::SystemNow();
+  }
+}
+
+void DomManager::RecordDomEndTimePoint() {
+  if (dom_end_time_point_.ToEpochDelta() == TimeDelta::Zero()) {
+    dom_end_time_point_ = footstone::TimePoint::SystemNow();
+  }
+}
+
 }  // namespace dom
 }  // namespace hippy
diff --git a/dom/src/dom/root_node.cc b/dom/src/dom/root_node.cc
@@ -277,6 +277,10 @@ void RootNode::SyncWithRenderManager(const std::shared_ptr<RenderManager>& rende
   FlushDomOperations(render_manager);
   FlushEventOperations(render_manager);
   DoAndFlushLayout(render_manager);
+  auto dom_manager = dom_manager_.lock();
+  if (dom_manager) {
+    dom_manager->RecordDomEndTimePoint();
+  }
   render_manager->EndBatch(GetWeakSelf());
 }
 

diff --git a/dom/src/dom/scene_builder.cc b/dom/src/dom/scene_builder.cc
@@ -33,6 +33,7 @@ void SceneBuilder::Create(const std::weak_ptr<DomManager>& weak_dom_manager,
                           std::vector<std::shared_ptr<DomInfo>>&& nodes) {
   auto dom_manager = weak_dom_manager.lock();
   if (dom_manager) {
+    dom_manager->RecordDomStartTimePoint();
     dom_manager->CreateDomNodes(root_node, std::move(nodes));
   }
 }

diff --git a/driver/js/include/driver/performance/performance_navigation_timing.h b/driver/js/include/driver/performance/performance_navigation_timing.h
@@ -60,6 +60,8 @@ class PerformanceNavigationTiming : public PerformanceEntry {
   DEFINE_SET_AND_GET_METHOD(HippyJsEngineInitEnd, TimePoint, hippy_js_engine_init_end_)
   DEFINE_SET_AND_GET_METHOD(HippyRunApplicationStart, TimePoint, hippy_run_application_start_)
   DEFINE_SET_AND_GET_METHOD(HippyRunApplicationEnd, TimePoint, hippy_run_application_end_)
+  DEFINE_SET_AND_GET_METHOD(HippyDomStart, TimePoint, hippy_dom_start_)
+  DEFINE_SET_AND_GET_METHOD(HippyDomEnd, TimePoint, hippy_dom_end_)
   DEFINE_SET_AND_GET_METHOD(HippyFirstFrameStart, TimePoint, hippy_first_frame_start_)
   DEFINE_SET_AND_GET_METHOD(HippyFirstFrameEnd, TimePoint, hippy_first_frame_end_)
 #undef DEFINE_SET_AND_GET_METHOD
@@ -80,6 +82,8 @@ class PerformanceNavigationTiming : public PerformanceEntry {
   std::vector<BundleInfo> bundle_info_array_;
   TimePoint hippy_run_application_start_;
   TimePoint hippy_run_application_end_;
+  TimePoint hippy_dom_start_;
+  TimePoint hippy_dom_end_;
   TimePoint hippy_first_frame_start_;
   TimePoint hippy_first_frame_end_;
 };

diff --git a/driver/js/src/modules/performance/performance_navigation_timing_module.cc b/driver/js/src/modules/performance/performance_navigation_timing_module.cc
@@ -95,6 +95,8 @@ std::shared_ptr<ClassTemplate<PerformanceNavigationTiming>> RegisterPerformanceN
   ADD_PROPERTY(hippy_js_engine_init_end, "hippyJsEngineInitEnd", GetHippyJsEngineInitEnd)
   ADD_PROPERTY(hippy_run_application_start, "hippyRunApplicationStart", GetHippyRunApplicationStart)
   ADD_PROPERTY(hippy_run_application_end, "hippyRunApplicationEnd", GetHippyRunApplicationEnd)
+  ADD_PROPERTY(hippy_dom_start, "hippyDomStart", GetHippyDomStart)
+  ADD_PROPERTY(hippy_dom_end, "hippyDomEnd", GetHippyDomEnd)
   ADD_PROPERTY(hippy_first_frame_start, "hippyFirstFrameStart", GetHippyFirstFrameStart)
   ADD_PROPERTY(hippy_first_frame_end, "hippyFirstFrameEnd", GetHippyFirstFrameEnd)
 #undef ADD_PROPERTY

diff --git a/driver/js/src/scope.cc b/driver/js/src/scope.cc
@@ -525,7 +525,6 @@ void Scope::LoadInstance(const std::shared_ptr<HippyValue>& value) {
     DEFINE_AND_CHECK_SELF(Scope)
     // perfromance start time
     auto entry = self->GetPerformance()->PerformanceNavigation("hippyInit");
-    entry->SetHippyFirstFrameStart(footstone::TimePoint::SystemNow());
     entry->SetHippyRunApplicationStart(footstone::TimePoint::SystemNow());
 
     std::shared_ptr<Ctx> context = weak_context.lock();
@@ -561,6 +560,12 @@ void Scope::LoadInstance(const std::shared_ptr<HippyValue>& value) {
 
     // perfromance end time
     entry->SetHippyRunApplicationEnd(footstone::TimePoint::SystemNow());
+    auto dom_manager = self->GetDomManager().lock();
+    if (dom_manager) {
+      entry->SetHippyDomStart(dom_manager->GetDomStartTimePoint());
+      entry->SetHippyDomEnd(dom_manager->GetDomEndTimePoint());
+      entry->SetHippyFirstFrameStart(dom_manager->GetDomEndTimePoint());
+    }
   };
   auto runner = GetTaskRunner();
   if (footstone::Worker::IsTaskRunning() && runner == footstone::runner::TaskRunner::GetCurrentTaskRunner()) {