Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of error messages when 4 chars or sold #1003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terzisspy
Copy link

Related Issues

In this version I am trying to correct the issues mentioned on issues #870 and #1002.

Difference

When a username has exact 4 characters the message shown to the user is that "Username must have at least 5 characters" instead of the "Username is taken" that actually appears and when a username has been already sold in fragment.com the error message that appears to the user is "Username is taken" instead of the error message that is currently shown which is "Only a-z, 0-9, and underscore allowed" and could create misunderstandings.

Screenshots and Videos

Below you can see how it works in the app right now compared to how it works after these minor changes.

bug3.mp4
bug4.mp4
sol3.mp4
sol4.mp4

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants