Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENHANCING THE ACCESSORIES PRODUCTS SAME LIKE OTHER PAGES #682

Merged
merged 5 commits into from
Nov 1, 2024
Merged

ENHANCING THE ACCESSORIES PRODUCTS SAME LIKE OTHER PAGES #682

merged 5 commits into from
Nov 1, 2024

Conversation

laxmikandivalasa
Copy link
Contributor

@laxmikandivalasa laxmikandivalasa commented Oct 28, 2024 •
edited
Loading

resolved issue num #565
@Tejashri-Taral You can check for any other issues
I'd like to take any other inputs!!

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trend-trove-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 5:26am

@Tejashri-Taral
Copy link
Owner

Please resolve the conflicts

@laxmikandivalasa
Copy link
Contributor Author

can you check now? @Tejashri-Taral

Tejashri-Taral
Tejashri-Taral requested changes Oct 29, 2024
View reviewed changes
Copy link
Owner

@Tejashri-Taral Tejashri-Taral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted some accessories product please do check and do not remove any product

@laxmikandivalasa
Copy link
Contributor Author

TrendTrove.-.Ecommerce.-.Google.Chrome.2024-10-30.12-31-05.mp4

hey @Tejashri-Taral
I've not removed any but just modified the existing products...
earlier there were total 24 products..
I've just enhanced them...(above I've added the video)
can you check once again...

Tejashri-Taral
Tejashri-Taral requested changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@Tejashri-Taral Tejashri-Taral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Consider adjusting the width of the boxes so that the number of items per row is consistent

@laxmikandivalasa
Copy link
Contributor Author

@Tejashri-Taral the above video that I've sent is what i changed and its well organised
can you check again??

@Tejashri-Taral
Copy link
Owner

some row contains 4 product some 3
It should be consistent like each row should contain 4

@laxmikandivalasa
Copy link
Contributor Author

laxmikandivalasa commented Nov 1, 2024 •
edited
Loading

My changes are like this for the page...I don't know how it is coming for you
https://github.com/user-attachments/assets/de216936-dee9-403f-8161-158764d0622b
so once again can I send the pr

@laxmikandivalasa
Copy link
Contributor Author

can you check now @Tejashri-Taral ??

@Tejashri-Taral Tejashri-Taral merged commit 616c4e8 into Tejashri-Taral:main Nov 1, 2024
1 check passed
@laxmikandivalasa
Copy link
Contributor Author

I was expecting level2 label for this
can you assign level 2 since There were many lines of code included!!
@Tejashri-Taral

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tejashri-Taral Tejashri-Taral Tejashri-Taral approved these changes

Assignees

@laxmikandivalasa laxmikandivalasa

Labels
gssoc-ext hacktoberfest-accepted level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laxmikandivalasa @Tejashri-Taral