-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Techy API React Native #309
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, Laura! Be proud of yourself, from no knowledge of react Native to an entire mobile app!
<Title>This is your cool app!</Title> | ||
<Title>Go to App.js and start coding</Title> | ||
<Title>💅💅💅</Title> | ||
<Technician source={require('./assets/technicians-at-work.jpg')} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that you made it work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😊
App.js
Outdated
@@ -1,24 +1,48 @@ | |||
import React from 'react'; | |||
import styled from 'styled-components/native'; | |||
import TechyApi from './components/TechyApi'; | |||
import { ImageBackground } from 'react-native'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could remove this line, since it's not used.
components/TechyApi.js
Outdated
@@ -0,0 +1,57 @@ | |||
import React, { useState, useEffect } from 'react'; | |||
import { View, Text, TouchableOpacity } from 'react-native'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
View
and TouchableOpacity
are not used, so it's better to remove them here (you don't have to import them when they are styled with styled-components).
components/TechyApi.js
Outdated
margin-top: 20px; | ||
border-radius: 10px; | ||
border: 2px solid darkgreen; | ||
padding; 5px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your padding isn't applied here because you have a semi-colon instead of a colon, should be padding: 5px;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It´s the little things...right 😊
components/TechyApi.js
Outdated
border-radius: 10px; | ||
border: 2px solid darkgreen; | ||
padding; 5px; | ||
color: white; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property has no effect (you text on the button remains black), since you are trying to set a font color to a container. Try to apply this to Text
inside of the container instead.
const TechyApi = () => { | ||
const [techwords, setTechwords] = useState({}) | ||
|
||
const generateTechWords = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice API, I should try to learn some sentences ;)
components/TechyApi.js
Outdated
const Container = styled.View` | ||
flex: 1; | ||
justify-content: center; | ||
align-items: center; | ||
margin: 20px; | ||
width: 80%; | ||
padding-left: 20px; | ||
padding-right: 20px; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's just github that does that, but it seems that the indentation isn't right in some places, like here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its Github for sure, it doesn´t look like this in VSC :)
No description provided.