Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add witness data #18

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Add witness data #18

merged 3 commits into from
Feb 19, 2024

Conversation

THM222
Copy link
Contributor

@THM222 THM222 commented Feb 4, 2024

Addresses issue #17

Added the json to the raw (combined the 2 json files from the witness repo into a single file before importing data).
Updated the import script to support the witness data format.
Updated some of the existing data that was missing the proof url to include it.
Added new categories to support the categories in the witness data.

I'm not sure what to do about the duplicates we have in brands and companies (currently there are 63). I like the richer data in the brand schema e.g. for mcd:

name: McDonald's
status: avoid
description: |-
  **McDonald's** Israel announced that it's giving away thousands of free meals to the Israel Defence Forces and citizens.[^1]

  [^1]: https://www.businessinsider.com/mcdonalds-donating-thousands-meals-idf-israeli-citizens-hamas-attacks-2023

---
name: McDonalds
status: avoid
description: |-
  McDonalds Israel supports IDF by providing free food and drinks to Israeli militants. See tweet (click translate) for reference.[^1]

  Don't eat at McDonald's.
  Don't work for McDonald's.
  [^1]: https://twitter.com/McDonaldsIL/status/1715047104895230153
reasons:
- operations_in_israel
countries:
- global
categories:
- food
- drinks
logo_url: |-
  https://1000logos.net/wp-content/uploads/2017/03/McDonalds-logo-500x281.png
alternatives_text:
- Local family owned restaurants

or adidas:

name: Adidas
status: avoid
description: |-
  **Adidas Underwear Partnership**

  **Adidas Underwear** has partnered with **Delta Galil Industries**, Ltd. (DELT/Tel Aviv Stock Exchange), the global manufacturer and marketer of branded and private label apparel products for men, women, and children. **Delta Galil Industries** is an **Israeli** textile firm headquartered in **Tel Aviv**, with plants around the world.[^1]

  [^1]: https://adidasunderwear.com/pages/adidas-underwear-partnership
---
name: Adidas
status: avoid
description: |-
  Adidas uses israeli manufacturer, Delta Galil, to manufacture its underwear range.[^1]

  Don't buy Adidas products.
  Don't sell Adidas products.
  Don't work for Adidas.
  [^1]: https://adidasunderwear.com/pages/adidas-underwear-partnership/
reasons:
- operations_in_israel
countries:
- global
categories:
- clothing
logo_url: |-
  https://adidasunderwear.com/cdn/shop/files/Sportswear_Logo_BWp_180x.png
alternatives_text:
- Unbranded sportswear

enable overwrite files in import script
add missing proof urls to existing imported data
@THM222 THM222 force-pushed the add_witness_data branch 2 times, most recently from 94c62f9 to a190b8b Compare February 4, 2024 16:21
@dev4justice
Copy link

If you've noticed, Witness data structure has a lot of "don't buy/sell/work" entries for "how to boycott" and I want to propose a few things here:

  1. Add "how to boycott" (or similar) section to your schema so it can be a clear actionable thing we can ask the users to take
  2. Convert those "don't buy/sell/work" stuff to something similar to the reasons (like operations_in_israel) so it can be localized in the apps
  3. Create "brand" objects for alternatives like "Unbranded products" or "Local stores" so they can be referred from the alternatives as a reference
  4. Use id fields for each brand so it can be used as a reference in the alternatives in the case above and maybe potentially like a relationship tracking ("parent/sibling" companies)

@THM222
Copy link
Contributor Author

THM222 commented Feb 5, 2024

If you've noticed, Witness data structure has a lot of "don't buy/sell/work" entries for "how to boycott" and I want to propose a few things here:

  1. Add "how to boycott" (or similar) section to your schema so it can be a clear actionable thing we can ask the users to take

  2. Convert those "don't buy/sell/work" stuff to something similar to the reasons (like operations_in_israel) so it can be localized in the apps

  3. Create "brand" objects for alternatives like "Unbranded products" or "Local stores" so they can be referred from the alternatives as a reference

  4. Use id fields for each brand so it can be used as a reference in the alternatives in the case above and maybe potentially like a relationship tracking ("parent/sibling" companies)

  1. @idris to comment on adding how to boycott to the schema. Going thru the data it looks mostly hardcoded sentences, with the brand name inserted. From a personal perspective, while i appreciate this guidance, im not sure these instructions should be on the main data source.

  2. Reasons is supposed to represent boycott reason.. whether its operations/deals with israel, settlements, or ceo/executive supporting.. things like this

  3. Note that we have alternatives_text field for unbranded. Is this sufficient? Or do you still think we need an unbranded file for every category?

  4. If you look at the output json, you'll see the id is there. The parent company id is used in the stakeholder section of the brand (not all have a stakeholder at the moment).

@dev4justice
Copy link

@idris to comment on adding how to boycott to the schema. Going thru the data it looks mostly hardcoded sentences, with the brand name inserted. From a personal perspective, while i appreciate this guidance, im not sure these instructions should be on the main data source

All I was bringing up was to either create a new "how to" section or not add that as part of the description (which is what your script generated)

Reasons is supposed to represent boycott reason.. whether its operations/deals with israel, settlements, or ceo/executive supporting.. things like this

I totally get it, I was suggesting a similar structure to the "reasons", e.g. do_not_buy_product/do_not_work

Note that we have alternatives_text field for unbranded. Is this sufficient? Or do you still think we need an unbranded file for every category?

I noticed that under "alternatives" it's a free-form string so I thought if we were to have a "brand" that was a generic "unbranded" data structure we could refer to that as part of the alternative. So we could use the alternatives as a list of brand_ids that we support. For example: for adidas it could be any "supporting" brand: [unbranded, mamasia, anz_clothing...]

If you look at the output json, you'll see the id is there. The parent company id is used in the stakeholder section of the brand (not all have a stakeholder at the moment).

Yes, as long as there's a section like stakeholders, that's fine (it's not a big deal even if we don't have it though)

@THM222 THM222 merged commit 56f371f into main Feb 19, 2024
3 checks passed
@THM222 THM222 deleted the add_witness_data branch February 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants