remove -1 for unknown systemBrightnes and default to 0.5 always

TeamNewPipe · Oct 23, 2024 · 81b32dd · 81b32dd
1 parent 3b015df
commit 81b32dd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/...ayer/src/main/java/net/newpipe/newplayer/ui/videoplayer/gesture_ui/FullscreenGestureUI.kt b/...ayer/src/main/java/net/newpipe/newplayer/ui/videoplayer/gesture_ui/FullscreenGestureUI.kt
@@ -92,7 +92,7 @@ internal fun FullscreenGestureUI(
         if (LocalContext.current is Activity)
             getDefaultBrightness(LocalContext.current as Activity)
         else
-            -1f
+            0.5f
 
     val embeddedUiConfig =
         if (LocalContext.current is Activity)

diff --git a/new-player/src/main/java/net/newpipe/newplayer/uiModel/NewPlayerViewModelImpl.kt b/new-player/src/main/java/net/newpipe/newplayer/uiModel/NewPlayerViewModelImpl.kt
@@ -565,12 +565,9 @@ class NewPlayerViewModelImpl @Inject constructor(
 
     override fun brightnessChange(changeRate: Float, systemBrightness: Float) {
         mutableUiState.update {
-            // TODO I would remove this `if`, and rather make it so that `brightnessChange` is
-            //  called only with a valid value for systemBrightness (so replace -1f with 0.5f
-            //  in FullscreenGestureUi
             if (it.uiMode.fullscreen) {
                 val currentBrightness = it.brightness
-                    ?: if (systemBrightness < 0f) 0.5f else systemBrightness
+                    ?: systemBrightness
                 Log.d(
                     TAG,
                     "currentBrightnes: $currentBrightness, sytemBrightness: $systemBrightness, changeRate: $changeRate"