don't make it so the ui asks for the insets controller every recompos…

…ition
TeamNewPipe · Oct 23, 2024 · 75cb373 · 75cb373
1 parent b44acdd
commit 75cb373
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/new-player/src/main/java/net/newpipe/newplayer/ui/NewPlayerUI.kt b/new-player/src/main/java/net/newpipe/newplayer/ui/NewPlayerUI.kt
@@ -87,14 +87,7 @@ fun NewPlayerUI(
         val activity = LocalContext.current as Activity
         val view = LocalView.current
 
-        // TODO this is a side-effect of the composition and should (probably) not happen on every
-        //  recomposition
         val window = activity.window
-        val windowInsetsController = WindowCompat.getInsetsController(window, window.decorView)
-        windowInsetsController.systemBarsBehavior =
-            WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
-
-        val defaultBrightness = getDefaultBrightness(activity)
 
         // Setup fullscreen
 
@@ -121,6 +114,10 @@ fun NewPlayerUI(
         LaunchedEffect(
             key1 = uiState.uiMode.systemInsetsVisible,
         ) {
+            val windowInsetsController = WindowCompat.getInsetsController(window, window.decorView)
+            windowInsetsController.systemBarsBehavior =
+                WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
+
             if (uiState.uiMode.systemInsetsVisible) {
                 windowInsetsController.show(WindowInsetsCompat.Type.systemBars())
             } else {
@@ -149,6 +146,8 @@ fun NewPlayerUI(
 
         LaunchedEffect(key1 = uiState.brightness) {
             Log.d(TAG, "New Brightnes: ${uiState.brightness}")
+            val defaultBrightness = getDefaultBrightness(activity)
+
             setScreenBrightness(
                 uiState.brightness ?: defaultBrightness, activity
             )