Update CommandAPI to 9.4.0 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmdinnc
reviewed
May 9, 2024
| .withArguments(new StringArgument("label").replaceSuggestions(RespawnManager.SUGGESTIONS_STRUCTURES)) | ||
| .withArguments(new TextArgument("special_structure_path")) | ||
| .withArguments(labelArg) | ||
| .withOptionalArguments(pathArg) |
There was a problem hiding this comment.
Should this be optional? it's nullable in there, but in implementation it's checking if null or empty and forcing failure
There was a problem hiding this comment.
Yeah, looks like it. Not sure why it was written before to have a command that always failed... Fixing
|
|
||
| new CommandAPICommand(command) | ||
| .withPermission(perms) | ||
| .withArguments(new StringArgument("label").replaceSuggestions(RespawnManager.SUGGESTIONS_STRUCTURES)) | ||
| .withOptionalArguments(labelArg) |
There was a problem hiding this comment.
Same here, if we're checking null later, we shouldn't leave it optional
There was a problem hiding this comment.
This one should be optional - if it is null it lists all structures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.