Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant first kills to other nearby players #65

Merged
merged 2 commits into from
Sep 7, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,26 @@ public void entityDeathEvent(EntityDeathEvent event) {
}
});
} else {
// Not a boss, just record kill for the killer
// Not a boss, record kill for the killer
try {
mStorage.recordKill(player, soul);
} catch (Exception ex) {
mLogger.warning(ex.getMessage());
}

// also check if any nearby player has not killed that mob before, and give them the kill
// good for both unlocking the entry in group play, and also to stop descriptions from showing up too many times
List<Player> otherPlayers = player.getWorld().getPlayers();
otherPlayers.remove(player);
otherPlayers.removeIf(p -> p.getLocation().distance(player.getLocation()) > 20);
FrozenEarth-git marked this conversation as resolved.
Show resolved Hide resolved
otherPlayers.removeIf(p -> getKillsForMob(p, soul) > 0);
for (Player p : otherPlayers) {
try {
mStorage.recordKill(p, soul);
} catch (Exception ex) {
mLogger.warning(ex.getMessage());
}
}
}
}
} catch (Exception ex) {
Expand Down
Loading