Fix compile warnings, add checkstyle & pmd errors for testing

Signed-off-by: Byron Marohn <[email protected]>
TeamMonumenta · May 3, 2024 · d4b3918 · d4b3918
1 parent 934434b
commit d4b3918
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/pullrequest.yml b/.github/workflows/pullrequest.yml
@@ -48,6 +48,6 @@ jobs:
         set -o pipefail
         ./gradlew build --console=plain 2>&1 | tee compile.log
         set +o pipefail
-        cat compile.log | reviewdog -efm="%W%f:%l: warning: %m" -efm="%+C%[ %\t]%.%#" -name="compiler-warnings" -level=error -fail-on-error -reporter=github-pr-check
+        cat compile.log | reviewdog -efm="%f:%l: warning:%m" -name="compiler-warnings" -level=error -fail-on-error -reporter=github-pr-check
         cat build/reports/pmd/main.xml | reviewdog -efm='%+P<file name="%f">' -efm='%W<violation beginline="%l%.%#begincolumn="%c%.%#' -efm='%-C<%.%#' -efm='%+C%.%#' -efm='%-Q' -name="pmd" -level=error -fail-on-error -reporter=github-pr-check
         cat build/reports/checkstyle/main.xml | reviewdog -f=checkstyle -name="checkstyle (adapterapi)" -level=error -fail-on-error -reporter=github-pr-check
diff --git a/src/main/java/com/playmonumenta/libraryofsouls/SoulPartyEntry.java b/src/main/java/com/playmonumenta/libraryofsouls/SoulPartyEntry.java
@@ -22,7 +22,7 @@ public class SoulPartyEntry implements SoulGroup {
 	public SoulPartyEntry(List<SoulPartyHistoryEntry> history) throws Exception {
 		mHistory = history;
 
-		String refLabel = history.get(0).getLabel();
+		String refLabel = history.get(0 ).getLabel();
 
 		for (SoulPartyHistoryEntry entry : history) {
 			if (!entry.getLabel().equals(refLabel)) {

diff --git a/src/main/java/com/playmonumenta/libraryofsouls/SoulsDatabase.java b/src/main/java/com/playmonumenta/libraryofsouls/SoulsDatabase.java
@@ -102,8 +102,6 @@ public SoulsDatabase(Plugin plugin, boolean loadHistory) throws Exception {
 					mIgnoreNextChange = false;
 				}
 			} catch (Exception e) {
-				mPlugin.getLogger().warning("Caught exception while polling database file: " + e.getMessage());
-				e.printStackTrace();
 			}
 		}, 200, 200);