Fix github actions / reviewdog warnings not being detected, fix null …

…warning (#55) Signed-off-by: Byron Marohn <[email protected]>
TeamMonumenta · May 3, 2024 · b5c6680 · b5c6680
1 parent a72712c
commit b5c6680
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/pullrequest.yml b/.github/workflows/pullrequest.yml
@@ -48,6 +48,6 @@ jobs:
         set -o pipefail
         ./gradlew build --console=plain 2>&1 | tee compile.log
         set +o pipefail
-        cat compile.log | reviewdog -efm="%W%f:%l: warning: %m" -efm="%+C%[ %\t]%.%#" -name="compiler-warnings" -reporter=github-pr-check
-        cat build/reports/pmd/main.xml | reviewdog -efm='%+P<file name="%f">' -efm='%W<violation beginline="%l%.%#begincolumn="%c%.%#' -efm='%-C<%.%#' -efm='%+C%.%#' -efm='%-Q' -name="pmd" -reporter=github-pr-check
-        cat build/reports/checkstyle/main.xml | reviewdog -f=checkstyle -name="checkstyle" -reporter=github-pr-check
+        cat compile.log | reviewdog -efm="%f:%l: warning:%m" -name="compiler-warnings" -level=error -fail-on-error -reporter=github-pr-check
+        cat build/reports/pmd/main.xml | reviewdog -efm='%+P<file name="%f">' -efm='%W<violation beginline="%l%.%#begincolumn="%c%.%#' -efm='%-C<%.%#' -efm='%+C%.%#' -efm='%-Q' -name="pmd" -level=error -fail-on-error -reporter=github-pr-check
+        cat build/reports/checkstyle/main.xml | reviewdog -f=checkstyle -name="checkstyle" -level=error -fail-on-error -reporter=github-pr-check
diff --git a/src/main/java/com/playmonumenta/libraryofsouls/LibraryOfSoulsAPI.java b/src/main/java/com/playmonumenta/libraryofsouls/LibraryOfSoulsAPI.java
@@ -58,7 +58,7 @@ public static Set<String> getSoulLocations() {
 		return db.listMobLocations();
 	}
 
-	public static List<Component> getDescription(String soulName) {
+	public static @Nullable List<Component> getDescription(String soulName) {
 		SoulsDatabase db = SoulsDatabase.getInstance();
 		SoulEntry soul = db.getSoul(soulName);
 		if (soul == null) {