-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Feat] 연관 레크레이션 목록 API구현 및 예외처리 추가 #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
88dldl
changed the title
✨ [Feat] 연관레크레이션 목록 API구현 및 예외처리 추가
✨ [Feat] 연관 레크레이션 목록 API구현 및 예외처리 추가
Jan 25, 2024
eomgerm
requested changes
Jan 26, 2024
src/main/java/com/avab/avab/dto/response/RecreationResponseDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/com/avab/avab/dto/response/RecreationResponseDTO.java
Outdated
Show resolved
Hide resolved
src/main/java/com/avab/avab/repository/RecreationCustomRepository.java
Outdated
Show resolved
Hide resolved
src/main/java/com/avab/avab/controller/RecreationController.java
Outdated
Show resolved
Hide resolved
eomgerm
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 제가 말씀드린 거랑 좀 다르게 하셨는데... 혹시 그냥 제가 수정해서 커밋해도 될까...요...?
아 넵!! 그래주시면 감사하겠습니다 ! |
# Conflicts: # src/main/java/com/avab/avab/security/SecurityConfig.java
# Conflicts: # src/main/java/com/avab/avab/controller/UserController.java # src/main/java/com/avab/avab/repository/RecreationCustomRepositoryImpl.java
eomgerm
approved these changes
Jan 31, 2024
jinuklee777
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 PR 타입 (하나 이상 선택)
❗️ 관련 이슈 링크
Close #38
📌 개요
🔁 변경 사항
Elastic search로 하다가는 시간이 오래 걸릴 것 같아 Querydsl 사용했습니다 !
-> 좀 더 나은 로직이 있다면 알려주세요!!!
이전에 구현한 레크레이션 상세설명 부분에 예외처리 추가했습니다. 134ea2e
📸 스크린샷
👀 기타 더 이야기해볼 점
✅ 체크 리스트