Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 2차 리팩토링 #206

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[REFACTOR] 2차 리팩토링 #206

merged 1 commit into from
Feb 20, 2024

Conversation

unanchoi
Copy link
Contributor

@unanchoi unanchoi commented Feb 20, 2024 •
edited
Loading

Related issue 🚀

Work Description 💚

  • 1차 리팩토링 이후에 리뷰 받은 내용을 기반으로 리팩토링을 진행헀습니다.

@unanchoi unanchoi changed the title Refactor #198 unan2 [REFACTOR Feb 20, 2024
@unanchoi unanchoi changed the title [REFACTOR [REFACTOR] 2차 리팩토링 Feb 20, 2024
@unanchoi unanchoi self-assigned this Feb 20, 2024
@unanchoi unanchoi requested a review from thguss February 20, 2024 13:57
@thguss thguss changed the base branch from develop to refactor_#198 February 20, 2024 13:58
thguss
thguss approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳! 좋습니다~

@thguss
Copy link
Member

thguss commented Feb 20, 2024

CI 실패는 코틀린 때문에 그런 것 같은데, 제 쪽에서 수정되어 있으니 일단 merge해도 좋을 듯 합니다!

@unanchoi unanchoi merged commit 354e0b9 into refactor_#198 Feb 20, 2024
1 check failed
@unanchoi unanchoi deleted the refactor_#198_unan2 branch February 20, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thguss thguss thguss approved these changes

Assignees

@unanchoi unanchoi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 멀티모듈 분리
2 participants
@unanchoi @thguss