Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] 홈 뷰 #90

Merged
merged 16 commits into from
Jan 19, 2024
Merged

[QA] 홈 뷰 #90

merged 16 commits into from
Jan 19, 2024

Conversation

Jokwanhee
Copy link
Collaborator

📌 관련 이슈

📷 screenshot

📝 Work Desciption

  • 홈 UI 동작 QA 수정
  • 권한 허용 시 게이지 이탈 수정
  • 목표 걸음 달성 시 운동 인증하기 버튼 활성화
  • 나/상대 목표 걸음 수 달성 시 하이파이브! + 이미지 변경

📚 Reference 혹은 궁금한 사항들

부족한 부분이 있는데 잘 부탁드립니다.

@Jokwanhee Jokwanhee added Pull Request 🔥 pr 날릴때 관희 🐪  PT쌤 QA qa 관련 작업 labels Jan 19, 2024
@Jokwanhee Jokwanhee added this to the Phase3 milestone Jan 19, 2024
@Jokwanhee Jokwanhee self-assigned this Jan 19, 2024
l2zh
l2zh approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@l2zh l2zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했습니다

@Jokwanhee Jokwanhee merged commit 7c11160 into develop Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2zh l2zh l2zh approved these changes

@giovannijunseokim giovannijunseokim Awaiting requested review from giovannijunseokim

@hyunjium hyunjium Awaiting requested review from hyunjium

Assignees

@Jokwanhee Jokwanhee

Labels
Pull Request 🔥 pr 날릴때 QA qa 관련 작업 관희 🐪  PT쌤
Projects
[Motiroid] Phase 3
Status: 🤝 Done
Milestone
Phase3
Development

Successfully merging this pull request may close these issues.
2 participants
@Jokwanhee @l2zh