Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Teacher Home Feature #172

Merged
merged 24 commits into from
Sep 7, 2024
Merged

[Core] Teacher Home Feature #172

merged 24 commits into from
Sep 7, 2024

Conversation

8954sood
Copy link
Member

@8954sood 8954sood commented Sep 6, 2024

Overview (Required)

  • Developed a home screen.
  • DDS Version up to 1.0.4
  • Ktor HttpClient Engine Set iOS to Dawin And Android to CIO cause by If iOS use CIO Engine then TLS Error
  • Coil Version up to 3.0.0-alpha06
  • Ktor Version up to 3.0.0-wasm
  • Add Multiplatform Coil Plugin

Screenshot

Android iOS

Issue

@8954sood
chore: Update Coil, Ktor Version
86838b0 
Coil의 CMM 호환이 3.0.0부터 지원되어 모두 업데이트 하였습니다.
@8954sood
feat: Create Home Banner Component And Fix Coil
b8abe04
@8954sood
refactor: Create Multiplatform Coil Plugin
5bbc1c4
@8954sood
feat: Create Home Meal Card
a0697f6
@8954sood
chore: Remove Banner Placeholder Image
23452a3
@8954sood
feat: Create Home Out Card
c2b68fb
@8954sood
feat: Create Home Night Study Card
2c54119
@8954sood
feat: Create Common Dodam Date
126c71b
@8954sood
feat: Create Home Scedule Card
9c346ab
@8954sood
feat: Home Add Bottom Spacer
e5b7b1e
@8954sood
feat: Meal Connect Remote
0f68ea0
@8954sood
feat: Add Shimmer
517c62c
@8954sood
feat: Create Home Banner Remote
0656a72
@8954sood
feat: Create Night Study Remote
9ea49d0
@8954sood
feat: Create Home Outing Remote
1ee40bb
@8954sood
refactor: Improved Home Code Readability
5267306
@8954sood
feat: Create Home Schedule Remote
b6a1eae
@8954sood
fix: Ktor Client iOS TLS Error
efc12bf
@8954sood
fix: iOS Not Load Schedule
4ddb205
@8954sood
feat: Create Home Pull Refresh
f0a08a6
@8954sood
fix: Home Meal Text Margin
08c8727
@8954sood
refactor: Not Show Loading UI
f9993d3
@8954sood
style: Apply Spotless Format
c3efc63
@8954sood 8954sood added the enhancement New feature or request label Sep 6, 2024
@8954sood 8954sood self-assigned this Sep 6, 2024
SeokgyuYun
SeokgyuYun reviewed Sep 7, 2024
View reviewed changes
Copy link
Member

@SeokgyuYun SeokgyuYun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대기중인 학생이 없을때 0명 대기중으로 표시하지 말고 대기중인 학생이 1명 이상일때만 대기중 버튼을 보여주도록 해주세요

@8954sood
Copy link
Member Author

8954sood commented Sep 7, 2024

대기중인 학생이 없을때 0명 대기중으로 표시하지 말고 대기중인 학생이 1명 이상일때만 대기중 버튼을 보여주도록 해주세요

반영하였습니다.

@8954sood 8954sood merged commit 921b3d8 into develop Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsi1212 wsi1212 wsi1212 approved these changes

@SeokgyuYun SeokgyuYun SeokgyuYun approved these changes

@wnsgur1 wnsgur1 Awaiting requested review from wnsgur1

Assignees

@8954sood 8954sood

Labels
enhancement New feature or request
Projects
None yet
Milestone
Dodamdodam Teacher development
Development

Successfully merging this pull request may close these issues.

Create Teacher Home Feature
3 participants
@8954sood @SeokgyuYun @wsi1212