Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach cmake about py2.7 and py3 (py2.7 is the default) #116

Merged
merged 6 commits into from
May 21, 2017
Merged

Teach cmake about py2.7 and py3 (py2.7 is the default) #116

merged 6 commits into from
May 21, 2017

Conversation

ermo
Copy link
Collaborator

@ermo ermo commented May 21, 2017

This might come in handy when it comes to adding full
py3 compatibility at a later stage per issue #88 .

Copy link
Owner

@Taose Taose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well commented, and changes are quite simple in nature.

Test has been conducted to confirm the relevant change, code compiles and runs, change is appropriate. No further testing required.

Copy link
Owner

@Taose Taose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear to cause problems that initially rendered Python3 unusable and updates to modern standards.

@Taose Taose changed the base branch from master to experimental May 21, 2017 15:00
@Taose Taose merged commit dad6ec5 into Taose:experimental May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants