Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isSubmitSuccessful prop #919

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

s-coimbra21
Copy link

@s-coimbra21 s-coimbra21 commented Aug 21, 2024

This adds a new prop the form state called isSubmitSuccessful. My use case for this is that there is no good way to keep input/submission disabled when a form that calls a server action which redirects the user when the form is successful.

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, great value add!

# Conflicts:
#	packages/form-core/tests/FormApi.spec.ts
Copy link

nx-cloud bot commented Oct 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5bcbe88. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@919

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@919

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@919

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@919

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@919

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@919

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@919

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@919

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@919

commit: 5bcbe88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants