Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabby-agent): correctly handle auto widget completion Item #3531

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Sma1lboy
Copy link
Collaborator

@Sma1lboy Sma1lboy commented Dec 7, 2024

refer to comment in clients/tabby-agent/src/codeCompletion/contexts.ts

cons| -> console
completionItem: console
insertPosition: 4
insertSeg: ole
currSeg: cons

We should not continue processing the autocomplete item if the completionItem is "console" but the user typed "cnt" as currSeg. Make sure that the characters typed by the user that trigger the completionItem match the completionItem’s prefix.

@Sma1lboy Sma1lboy requested a review from icycodes December 7, 2024 22:16
@Sma1lboy Sma1lboy changed the title fix(tabby-agent): correctly handle auto widget auto completion Item fix(tabby-agent): correctly handle auto widget completion Item Dec 7, 2024
@icycodes icycodes merged commit 5fb03f2 into TabbyML:main Dec 9, 2024
4 checks passed
@Sma1lboy Sma1lboy deleted the fix-validating-by-wrong-seg branch December 10, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants