Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(models-http-api): add rate limit support for embedding #3466

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Nov 26, 2024

CleanShot 2024-11-26 at 10 51 07@2x

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 6.66667% with 70 lines in your changes missing coverage. Please review.

Project coverage is 63.16%. Comparing base (8bcaf05) to head (e660de9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/http-api-bindings/src/embedding/mod.rs 0.00% 50 Missing ⚠️
crates/http-api-bindings/src/embedding/openai.rs 0.00% 7 Missing ⚠️
crates/http-api-bindings/src/embedding/voyage.rs 0.00% 7 Missing ⚠️
crates/http-api-bindings/src/embedding/llama.rs 0.00% 3 Missing ⚠️
crates/ollama-api-bindings/src/embedding.rs 0.00% 2 Missing ⚠️
crates/tabby-common/src/config.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3466      +/-   ##
==========================================
- Coverage   63.31%   63.16%   -0.16%     
==========================================
  Files         193      193              
  Lines       22019    22111      +92     
==========================================
+ Hits        13941    13966      +25     
- Misses       8078     8145      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwpaper zwpaper requested a review from wsxiaoys November 26, 2024 03:11
@wsxiaoys wsxiaoys enabled auto-merge (squash) November 26, 2024 03:13
@wsxiaoys wsxiaoys merged commit 8e3e449 into main Nov 26, 2024
4 of 6 checks passed
@wsxiaoys wsxiaoys deleted the feat/simple-rate-limit branch November 26, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants