-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabby-chat-panel): adding capability check in tabby-ui and adding applyInEditorV2 #3432
Merged
wsxiaoys
merged 29 commits into
TabbyML:main
from
Sma1lboy:feat-webui-check-capabilities
Nov 30, 2024
Merged
feat(tabby-chat-panel): adding capability check in tabby-ui and adding applyInEditorV2 #3432
wsxiaoys
merged 29 commits into
TabbyML:main
from
Sma1lboy:feat-webui-check-capabilities
Nov 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
reviewed
Nov 21, 2024
update: waiting for tabby-threads modification first |
Sma1lboy
force-pushed
the
feat-webui-check-capabilities
branch
from
November 27, 2024 07:46
73fb409
to
8380c9a
Compare
Sma1lboy
changed the title
feat(tabby-chat-panel): adding capabilities check in client api
feat(tabby-chat-panel): adding capability check in tabby-ui and adding applyInEditorV2
Nov 27, 2024
…act.ts - In index.ts, update the second parameter of the createClient function from `api: ClientApi` to `api: ClientApiMethods`. - In react.ts, update the second parameter of the useClient function from `api: ClientApi` to `api: ClientApiMethods`.
The `clientApiKeys` array is added to export the available client API methods. This array includes keys for methods such as `navigate`, `refresh`, `onSubmitMessage`, `onApplyInEditor`, `onApplyInEditorV2`, `onLoaded`, `onCopy`, and `onKeyboardEvent`. This change enhances the functionality of the `ClientApi` interface.
Sma1lboy
force-pushed
the
feat-webui-check-capabilities
branch
from
November 28, 2024 03:10
c19c987
to
bf4f8d8
Compare
Update the second parameter of the createClient function in index.ts and the useClient function in react.ts from `api: ClientApi` to `api: ClientApiMethods`. This change improves the clarity and consistency of the function parameter names.
wsxiaoys
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Update the second parameter of the createClient function in index.ts and the useClient function in react.ts from `api: ClientApi` to `api: ClientApiMethods`. This change improves the clarity and consistency of the function parameter names.
Sma1lboy
force-pushed
the
feat-webui-check-capabilities
branch
from
November 30, 2024 02:22
822b69d
to
f1ad5fb
Compare
wsxiaoys
pushed a commit
that referenced
this pull request
Dec 9, 2024
…g applyInEditorV2 (#3432) * feat: add hasCapability method to ClientApi interface * feat: adding custom createThread implementation * feat: add createThreadInsideIframe module and update dependencies * [autofix.ci] apply automated fixes * feat: add CHECK_CAPABILITY method to createThread function * feat: update server capabilities in ChatPage component * [autofix.ci] apply automated fixes * feat: add ChatContext to AssistantMessageSection component * feat(tabby-thread): adding tabby threads package * feat(tabby-threads): add customized version of @quilted/threads for Tabby project, also added readme * feat: add CHECK_CAPABILITY method to target.ts * feat: update dependencies for tabby-chat-panel and vscode clients * chore: delete custom thread * chore: remove custom thread * feat: adding apply in editor v2 * feat: implement applyEditorV2 on vscode * feat(web-ui): adding capability check, also auto apply applyEditor v1 and v2 * chore: adding a new interface to encapsulate client apis * chore: Update createClient function parameter name in index.ts and react.ts - In index.ts, update the second parameter of the createClient function from `api: ClientApi` to `api: ClientApiMethods`. - In react.ts, update the second parameter of the useClient function from `api: ClientApi` to `api: ClientApiMethods`. * [autofix.ci] apply automated fixes * chore: update tabby-chat-panel to version 0.3.0 * feat: Add clientApiKeys array to export available client API methods The `clientApiKeys` array is added to export the available client API methods. This array includes keys for methods such as `navigate`, `refresh`, `onSubmitMessage`, `onApplyInEditor`, `onApplyInEditorV2`, `onLoaded`, `onCopy`, and `onKeyboardEvent`. This change enhances the functionality of the `ClientApi` interface. * chore: Update createClient and useClient function parameter names Update the second parameter of the createClient function in index.ts and the useClient function in react.ts from `api: ClientApi` to `api: ClientApiMethods`. This change improves the clarity and consistency of the function parameter names. * chore: Update createClient and useClient function parameter names * chore: Update createClient and useClient function parameter names Update the second parameter of the createClient function in index.ts and the useClient function in react.ts from `api: ClientApi` to `api: ClientApiMethods`. This change improves the clarity and consistency of the function parameter names. --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on: tabby-ui hasCapability check and smartApplyV2
waiting for #3474