Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): add collapsible interaction to sidebar #3406

Merged
merged 10 commits into from
Nov 12, 2024
Merged

feat(ui): add collapsible interaction to sidebar #3406

merged 10 commits into from
Nov 12, 2024

Conversation

liangfung
Copy link
Collaborator

@liangfung liangfung commented Nov 11, 2024 •
edited
Loading

Changes

  1. Integrate the sidebar component from shadcn-ui.
  2. Adjust layout and modify some styles to optimize frame dropping issues.
  3. resolve the issue where the scrollbar does not return to the top of the page after navigation
  4. Resolve the issue of layout height fluctuations on some pages.

Screen record

https://jam.dev/c/752af652-2a0f-42f8-801b-7c27c7aaf2e6

@liangfung liangfung force-pushed the feat-ui-collapsible-sidebar branch from af4ad1d to a75847b Compare November 12, 2024 08:38
@liangfung liangfung marked this pull request as ready for review November 12, 2024 08:46
@wsxiaoys wsxiaoys merged commit 6b23503 into main Nov 12, 2024
4 checks passed
@wsxiaoys wsxiaoys deleted the feat-ui-collapsible-sidebar branch November 12, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsxiaoys wsxiaoys wsxiaoys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liangfung @wsxiaoys