Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(answer): return error when request to llm failed #3405

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Nov 11, 2024

after:

CleanShot 2024-11-12 at 00 50 03@2x

may need your help @liangfung, looks like it's different error handling from the GraphQL API

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.43%. Comparing base (4a26fc1) to head (48deb0c).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3405   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files         187      187           
  Lines       21236    21236           
=======================================
  Hits        13470    13470           
  Misses       7766     7766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys requested a review from liangfung November 11, 2024 18:24
@wsxiaoys wsxiaoys merged commit c5a46ab into main Nov 12, 2024
7 of 8 checks passed
@wsxiaoys wsxiaoys deleted the fix/answer-engine-report-error branch November 12, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants