Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codeSearch): normalize path for code search #3393

Conversation

Sma1lboy
Copy link
Collaborator

@Sma1lboy Sma1lboy commented Nov 9, 2024

working on it rn

building testing demo

@Sma1lboy Sma1lboy force-pushed the fix-normalize-slash-format-webui-settings-acticities branch from bf89bd2 to 5825605 Compare November 9, 2024 03:15
@Sma1lboy Sma1lboy changed the title fix: adding normalize base on os in webui settings fix: normalize path during build segment Nov 9, 2024
@Sma1lboy Sma1lboy requested a review from icycodes November 9, 2024 03:16
@Sma1lboy Sma1lboy force-pushed the fix-normalize-slash-format-webui-settings-acticities branch from 5825605 to 3d2682a Compare November 12, 2024 13:34
@Sma1lboy Sma1lboy force-pushed the fix-normalize-slash-format-webui-settings-acticities branch from 28ebe90 to b87cdc9 Compare November 12, 2024 22:36
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.45%. Comparing base (4a26fc1) to head (5655e90).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3393      +/-   ##
==========================================
+ Coverage   63.43%   63.45%   +0.02%     
==========================================
  Files         187      187              
  Lines       21236    21251      +15     
==========================================
+ Hits        13470    13485      +15     
  Misses       7766     7766              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@Sma1lboy Sma1lboy force-pushed the fix-normalize-slash-format-webui-settings-acticities branch from b239cd9 to c7b8bd3 Compare November 14, 2024 00:49
crates/tabby-common/src/api/code.rs Outdated Show resolved Hide resolved
crates/tabby-common/src/api/code.rs Outdated Show resolved Hide resolved
@icycodes icycodes changed the title fix: normalize path during build segment fix(codeSearch): normalize path for code search Nov 14, 2024
@icycodes icycodes removed their request for review November 14, 2024 01:22
@wsxiaoys wsxiaoys enabled auto-merge (squash) November 14, 2024 01:33
@wsxiaoys wsxiaoys disabled auto-merge November 14, 2024 02:12
@wsxiaoys wsxiaoys merged commit 414cac3 into TabbyML:main Nov 14, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants