-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codeSearch): normalize path for code search #3393
Merged
wsxiaoys
merged 11 commits into
TabbyML:main
from
Sma1lboy:fix-normalize-slash-format-webui-settings-acticities
Nov 14, 2024
Merged
fix(codeSearch): normalize path for code search #3393
wsxiaoys
merged 11 commits into
TabbyML:main
from
Sma1lboy:fix-normalize-slash-format-webui-settings-acticities
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sma1lboy
force-pushed
the
fix-normalize-slash-format-webui-settings-acticities
branch
from
November 9, 2024 03:15
bf89bd2
to
5825605
Compare
Sma1lboy
changed the title
fix: adding normalize base on os in webui settings
fix: normalize path during build segment
Nov 9, 2024
Sma1lboy
force-pushed
the
fix-normalize-slash-format-webui-settings-acticities
branch
from
November 12, 2024 13:34
5825605
to
3d2682a
Compare
wsxiaoys
reviewed
Nov 12, 2024
Sma1lboy
force-pushed
the
fix-normalize-slash-format-webui-settings-acticities
branch
from
November 12, 2024 22:36
28ebe90
to
b87cdc9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3393 +/- ##
==========================================
+ Coverage 63.43% 63.45% +0.02%
==========================================
Files 187 187
Lines 21236 21251 +15
==========================================
+ Hits 13470 13485 +15
Misses 7766 7766 ☔ View full report in Codecov by Sentry. |
wsxiaoys
reviewed
Nov 13, 2024
wsxiaoys
reviewed
Nov 13, 2024
wsxiaoys
reviewed
Nov 13, 2024
wsxiaoys
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
to: remove unuse import
Sma1lboy
force-pushed
the
fix-normalize-slash-format-webui-settings-acticities
branch
from
November 14, 2024 00:49
b239cd9
to
c7b8bd3
Compare
wsxiaoys
requested changes
Nov 14, 2024
icycodes
changed the title
fix: normalize path during build segment
fix(codeSearch): normalize path for code search
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on it rn
building testing demo