Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): reorganize settings #2501

Merged
merged 4 commits into from
Jun 25, 2024
Merged

feat(vscode): reorganize settings #2501

merged 4 commits into from
Jun 25, 2024

Conversation

wwayne
Copy link
Contributor

@wwayne wwayne commented Jun 25, 2024

Main changes

Update the settings page

Screenshot 2024-06-25 15 09 47

trigger mode in settings.json
Screenshot 2024-06-25 14 01 27

New context variable tabby.inlineCompletionTriggerMode

After putting inlineCompletionTriggerMode into settings.advanced, we can't visit config.tabby.settings.advanced.inlineCompletion.triggerMode
So I create a new context variable

Trigger mode testing

  • Command palette (toggle command)
  • Bottom-right popup for different trigger mode
  • Manually updating the settings.json

@wwayne wwayne requested a review from icycodes June 25, 2024 07:59
clients/vscode/src/Config.ts Outdated Show resolved Hide resolved
@wwayne wwayne requested a review from icycodes June 25, 2024 13:04
@icycodes icycodes merged commit a0491f9 into main Jun 25, 2024
4 checks passed
@icycodes icycodes deleted the vscode-settings branch June 25, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants