Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): chat panel display issues #2276

Merged
merged 13 commits into from
May 29, 2024
Merged

fix(vscode): chat panel display issues #2276

merged 13 commits into from
May 29, 2024

Conversation

wwayne
Copy link
Contributor

@wwayne wwayne commented May 29, 2024

Notable changes

  • Left side icon
  • Static content display (see the screenshots below)
  • Fix the issue: setup token or other configuration makes the page empty
    • How to reproduce: open chat -> close chat -> change config -> re-open chat
    • Why: when webview invisible, the webview.postMessage actually won't work, we need webview.postMessage to init our chat page, so I add an listener to the visibility, and add init event when visible, if the webview is already inited, sending init event won't break the page

Before user setup the server, previously this page is empty

1

After connection, the config changed and somehow the chat panel is unavailable

2

@wwayne wwayne requested a review from icycodes May 29, 2024 07:15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use the version with background to enable better circle avatar display

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or you can add background color with css

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 2

@icycodes icycodes merged commit fcdfc8a into main May 29, 2024
4 checks passed
@icycodes icycodes deleted the chatpanel-fix branch May 29, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants