Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scheduler): key format for dataset bucket should be relative file… #2023

Merged
merged 4 commits into from
May 2, 2024
Merged

fix(scheduler): key format for dataset bucket should be relative file… #2023

merged 4 commits into from
May 2, 2024

Conversation

wsxiaoys
Copy link
Member

@wsxiaoys wsxiaoys commented May 1, 2024

… path

@wsxiaoys wsxiaoys requested a review from boxbeam May 1, 2024 23:51
@wsxiaoys wsxiaoys enabled auto-merge (squash) May 1, 2024 23:58
@codecov Codecov
Copy link

codecov bot commented May 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 54.28%. Comparing base (5536adc) to head (3601b05).
Report is 1 commits behind head on main.

❗ Current head 3601b05 differs from pull request most recent head 08160ce. Consider uploading reports for the commit 08160ce to get more accurate results

Files Patch % Lines
crates/tabby-scheduler/src/repository_store.rs 0.00% 5 Missing ⚠️
crates/tabby-scheduler/src/dataset/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
+ Coverage   54.25%   54.28%   +0.02%     
==========================================
  Files         139      139              
  Lines       12697    12698       +1     
==========================================
+ Hits         6889     6893       +4     
+ Misses       5808     5805       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys merged commit 492c191 into main May 2, 2024
5 of 6 checks passed
@wsxiaoys wsxiaoys deleted the cleanup-cache-size branch May 2, 2024 00:08
wsxiaoys added a commit that referenced this pull request May 2, 2024
@wsxiaoys
fix(scheduler): key format for dataset bucket should be relative file… (
b2dfa8c 
#2023)

* fix(scheduler): key format for dataset bucket should be relative file path

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boxbeam boxbeam Awaiting requested review from boxbeam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wsxiaoys