Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webserver): add endpoint to calculate disk usage #1964

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

boxbeam
Copy link
Contributor

@boxbeam boxbeam commented Apr 25, 2024

cc @wwayne
Closes TAB-585

@boxbeam boxbeam requested a review from wsxiaoys April 25, 2024 17:34
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 57.12%. Comparing base (0420bde) to head (35d3c96).

Files Patch % Lines
ee/tabby-webserver/src/schema/analytic.rs 83.33% 2 Missing ⚠️
ee/tabby-webserver/src/service/analytic.rs 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   56.84%   57.12%   +0.28%     
==========================================
  Files         131      131              
  Lines       11562    11619      +57     
==========================================
+ Hits         6572     6637      +65     
+ Misses       4990     4982       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LG

ee/tabby-webserver/src/service/analytic.rs Outdated Show resolved Hide resolved
ee/tabby-webserver/src/service/analytic.rs Outdated Show resolved Hide resolved
ee/tabby-webserver/src/schema/analytic.rs Outdated Show resolved Hide resolved
ee/tabby-webserver/src/schema/analytic.rs Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys merged commit eb942ae into main Apr 25, 2024
7 of 8 checks passed
@wsxiaoys wsxiaoys deleted the storage-usage-api branch April 25, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants