Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): fix bugs based on sqlite date format difference from chrono #1951

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

boxbeam
Copy link
Contributor

@boxbeam boxbeam commented Apr 24, 2024

@boxbeam boxbeam requested a review from wsxiaoys April 24, 2024 18:37
@wsxiaoys
Copy link
Member

Please add a unit test to cover this situation.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 55.84%. Comparing base (fccd409) to head (6ad4c74).
Report is 2 commits behind head on main.

Files Patch % Lines
ee/tabby-db/src/lib.rs 86.66% 6 Missing ⚠️
ee/tabby-db/src/user_events.rs 0.00% 2 Missing ⚠️
ee/tabby-db/src/github_repository_provider.rs 85.71% 1 Missing ⚠️
ee/tabby-webserver/src/integrations/github.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1951      +/-   ##
==========================================
+ Coverage   55.71%   55.84%   +0.13%     
==========================================
  Files         132      132              
  Lines       11587    11637      +50     
==========================================
+ Hits         6456     6499      +43     
- Misses       5131     5138       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boxbeam boxbeam changed the title fix(db): fix repository refresh job fix(db): fix bugs based on sqlite date format difference from chrono Apr 24, 2024
@wsxiaoys wsxiaoys enabled auto-merge (squash) April 24, 2024 20:03
@boxbeam boxbeam disabled auto-merge April 24, 2024 20:47
@wsxiaoys
Copy link
Member

autofix is still broken?

@wsxiaoys wsxiaoys enabled auto-merge (squash) April 24, 2024 20:58
@wsxiaoys wsxiaoys merged commit 1b98db4 into main Apr 24, 2024
7 checks passed
@wsxiaoys wsxiaoys deleted the fix-repo-refresh-job branch April 24, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants