Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): don't count inactive users in stats #1939

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

boxbeam
Copy link
Contributor

@boxbeam boxbeam commented Apr 23, 2024

Fixes TAB-628

@boxbeam boxbeam requested a review from wsxiaoys April 23, 2024 20:52
@boxbeam boxbeam marked this pull request as ready for review April 23, 2024 20:52
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update CHANGELOG.md to record the fix.

Otherwise LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys enabled auto-merge (squash) April 23, 2024 20:59
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.96%. Comparing base (482afb8) to head (ec5bc61).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
+ Coverage   55.85%   55.96%   +0.11%     
==========================================
  Files         130      130              
  Lines       11493    11523      +30     
==========================================
+ Hits         6419     6449      +30     
  Misses       5074     5074              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys merged commit c162ffc into main Apr 23, 2024
7 checks passed
@wsxiaoys wsxiaoys deleted the fix-daily-stats-user-active branch April 23, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants