feat(ui): display storage usage #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
reviewed
Apr 23, 2024
| <p className="font-bold"> | ||
| Storage Usage | ||
| </p> | ||
| <p className="text-sm text-muted-foreground">Disk space used by Tabby</p> |
There was a problem hiding this comment.
Suggested change
| <p className="text-sm text-muted-foreground">Disk space used by Tabby</p> | |
| <p className="text-sm text-muted-foreground">Disk Space Utilization by Type</p> |
Prompt:
| @@ -47,6 +62,15 @@ export default function Workers() { | |||
|
|
|||
| if (!healthInfo) return | |||
|
|
|||
| // TODO: mock data | |||
There was a problem hiding this comment.
Suggested change
| // TODO: mock data | |
| // FIXME(wwayne): connect with backend api |
| @@ -47,6 +62,15 @@ export default function Workers() { | |||
|
|
|||
| if (!healthInfo) return | |||
|
|
|||
| // TODO: mock data | |||
| const usageData = [ | |||
| { name: "Models", usage: 1024 * 1024 * 1024 * 1.1, color: "#0088FE", folders: ["~/.tabby/models"] }, | |||
There was a problem hiding this comment.
remove folders hover for now to simplify backend api
|
Please also fix CI |
wsxiaoys
reviewed
Apr 23, 2024
| @@ -47,6 +62,15 @@ export default function Workers() { | |||
|
|
|||
| if (!healthInfo) return | |||
|
|
|||
| // TODO: mock data | |||
| const usageData = [ | |||
| { name: "Models", usage: 1024 * 1024 * 1024 * 1.1, color: "#0088FE", folders: ["~/.tabby/models"] }, | |||
There was a problem hiding this comment.
Suggested change
| { name: "Models", usage: 1024 * 1024 * 1024 * 1.1, color: "#0088FE", folders: ["~/.tabby/models"] }, | |
| { name: "Model Cache", usage: 1024 * 1024 * 1024 * 1.1, color: "#0088FE", folders: ["~/.tabby/models"] }, |
| // TODO: mock data | ||
| const usageData = [ | ||
| { name: "Models", usage: 1024 * 1024 * 1024 * 1.1, color: "#0088FE", folders: ["~/.tabby/models"] }, | ||
| { name: "Repository data", usage: 1024 * 1024 * 2.1, color: "#00C49F", folders: ["~/.tabby/dataset", "~/.tabby/index"] }, |
There was a problem hiding this comment.
Suggested change
| { name: "Repository data", usage: 1024 * 1024 * 2.1, color: "#00C49F", folders: ["~/.tabby/dataset", "~/.tabby/index"] }, | |
| { name: "Repository Context", usage: 1024 * 1024 * 2.1, color: "#00C49F", folders: ["~/.tabby/dataset", "~/.tabby/index"] }, |
| const usageData = [ | ||
| { name: "Models", usage: 1024 * 1024 * 1024 * 1.1, color: "#0088FE", folders: ["~/.tabby/models"] }, | ||
| { name: "Repository data", usage: 1024 * 1024 * 2.1, color: "#00C49F", folders: ["~/.tabby/dataset", "~/.tabby/index"] }, | ||
| { name: "Database", usage: 1024 * 85, color: "#FFBB28", folders: ["~/.tabby/ee"] }, |
There was a problem hiding this comment.
Suggested change
| { name: "Database", usage: 1024 * 85, color: "#FFBB28", folders: ["~/.tabby/ee"] }, | |
| { name: "Other", usage: 1024 * 85, color: "#FFBB28", folders: ["~/.tabby/ee"] }, |
| { name: "Models", usage: 1024 * 1024 * 1024 * 1.1, color: "#0088FE", folders: ["~/.tabby/models"] }, | ||
| { name: "Repository data", usage: 1024 * 1024 * 2.1, color: "#00C49F", folders: ["~/.tabby/dataset", "~/.tabby/index"] }, | ||
| { name: "Database", usage: 1024 * 85, color: "#FFBB28", folders: ["~/.tabby/ee"] }, | ||
| { name: "Events", usage: 1024 * 1200 * 11, color: "#FF8042", folders: ["~/.tabby/events"] } |
There was a problem hiding this comment.
Suggested change
| { name: "Events", usage: 1024 * 1200 * 11, color: "#FF8042", folders: ["~/.tabby/events"] } | |
| { name: "Event Logs", usage: 1024 * 1200 * 11, color: "#FF8042", folders: ["~/.tabby/events"] } |
wsxiaoys
reviewed
Apr 23, 2024
| fill={theme === 'dark' ? '#FDFDFD' : '#030302'} | ||
| className="text-sm" | ||
| > | ||
| Total Usuage |
There was a problem hiding this comment.
Suggested change
| Total Usuage | |
| Total Usage |
wwayne
force-pushed
the
ui-display-usage
branch
from
da64b6e to
9660038
Compare
wwayne
force-pushed
the
ui-display-usage
branch
from
84531de to
5c378ff
Compare
wsxiaoys
force-pushed
the
ui-display-usage
branch
from
5c378ff to
84da66e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
We already have pretty-bytes. Why import a new library bytes?
Pretty-bytes cannot convert the size data correctly. The reason should be:
Note that it uses base-10 (e.g. kilobyte)from pretty-bytes READMEScreen record: https://jam.dev/c/649c3857-52e5-4c46-9181-4addaa75b2e7
fix TAB-616