Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webserver): always use schema::Result for graphql api responses #1892

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

wsxiaoys
Copy link
Member

@wsxiaoys wsxiaoys requested a review from boxbeam April 18, 2024 17:56
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 56.05%. Comparing base (25f47a7) to head (7215c2a).
Report is 8 commits behind head on main.

Files Patch % Lines
ee/tabby-webserver/src/juniper/relay/mod.rs 21.42% 11 Missing ⚠️
ee/tabby-webserver/src/schema/mod.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1892      +/-   ##
==========================================
+ Coverage   55.42%   56.05%   +0.63%     
==========================================
  Files         125      125              
  Lines       11013    11099      +86     
==========================================
+ Hits         6104     6222     +118     
+ Misses       4909     4877      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys merged commit 5acc26d into main Apr 18, 2024
6 of 7 checks passed
@wsxiaoys wsxiaoys deleted the fix-schema-result branch April 18, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant