Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): turn on --webserver by default #1860

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

wsxiaoys
Copy link
Member

fix TAB-598

@wsxiaoys wsxiaoys requested a review from boxbeam April 16, 2024 17:07
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.11%. Comparing base (283f238) to head (7eb4ce7).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/tabby/src/serve.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
+ Coverage   54.53%   55.11%   +0.57%     
==========================================
  Files         123      123              
  Lines       10765    10995     +230     
==========================================
+ Hits         5871     6060     +189     
- Misses       4894     4935      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys force-pushed the turn-on-webserver-by-default branch from 2946ad0 to 532607e Compare April 16, 2024 17:16
crates/tabby/src/serve.rs Outdated Show resolved Hide resolved
@wsxiaoys wsxiaoys enabled auto-merge (squash) April 16, 2024 20:47
@wsxiaoys wsxiaoys merged commit ea68ac4 into main Apr 16, 2024
6 of 7 checks passed
@wsxiaoys wsxiaoys deleted the turn-on-webserver-by-default branch April 16, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants