Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webserver, db): Implement github provided repositories #1800
feat(webserver, db): Implement github provided repositories #1800
Changes from 10 commits
be2669b
7e83191
6a59023
f2ecece
5a3d004
beee719
4cc8ec0
c9659ad
bd71d56
282b56f
17be87a
b6fcc56
2405677
271d4d8
38e6645
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 127 in ee/tabby-db/src/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-db/src/github_repository_provider.rs#L127
Check warning on line 158 in ee/tabby-db/src/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-db/src/github_repository_provider.rs#L145-L158
Check warning on line 160 in ee/tabby-db/src/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-db/src/github_repository_provider.rs#L160
Check warning on line 182 in ee/tabby-db/src/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-db/src/github_repository_provider.rs#L182
Check warning on line 151 in ee/tabby-webserver/src/handler.rs
Codecov / codecov/patch
ee/tabby-webserver/src/handler.rs#L147-L151
Check warning on line 55 in ee/tabby-webserver/src/integrations/github.rs
Codecov / codecov/patch
ee/tabby-webserver/src/integrations/github.rs#L55
Check warning on line 66 in ee/tabby-webserver/src/integrations/github.rs
Codecov / codecov/patch
ee/tabby-webserver/src/integrations/github.rs#L66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The access token can be
None
(if the user has not gone through the OAuth connect flow yet), and this will only be used internally. I think we should prefer a closer representation of the data, since otherwise I'll be having to checkif access_token.is_empty()
instead.Check warning on line 22 in ee/tabby-webserver/src/schema/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-webserver/src/schema/github_repository_provider.rs#L17-L22
Check warning on line 57 in ee/tabby-webserver/src/schema/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-webserver/src/schema/github_repository_provider.rs#L55-L57
Check warning on line 61 in ee/tabby-webserver/src/schema/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-webserver/src/schema/github_repository_provider.rs#L59-L61
Check warning on line 65 in ee/tabby-webserver/src/schema/github_repository_provider.rs
Codecov / codecov/patch
ee/tabby-webserver/src/schema/github_repository_provider.rs#L63-L65
Check warning on line 257 in ee/tabby-webserver/src/schema/mod.rs
Codecov / codecov/patch
ee/tabby-webserver/src/schema/mod.rs#L253-L257
Check warning on line 286 in ee/tabby-webserver/src/schema/mod.rs
Codecov / codecov/patch
ee/tabby-webserver/src/schema/mod.rs#L276-L286