Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add Clone trait to the Declaration #1792

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(core): add Clone trait to the Declaration #1792

merged 1 commit into from
Apr 9, 2024

Conversation

wwayne
Copy link
Contributor

@wwayne wwayne commented Apr 9, 2024

To fix the error

error[E0277]: the trait bound `Declaration: Clone` is not satisfied
  --> crates/tabby-common/src/api/event.rs:98:5
   |
86 | #[derive(Serialize, Deserialize, Debug, Clone)]
   |                                         ----- in this derive macro expansion
...
98 |     pub declarations: Option<Vec<Declaration>>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Clone` is not implemented for `Declaration`, which is required by `std::option::Option<std::vec::Vec<Declaration>>: Clone`
   |

@wwayne wwayne requested a review from wsxiaoys April 9, 2024 03:38
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.40%. Comparing base (a372c6b) to head (a5ae2c6).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/tabby-common/src/api/event.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
+ Coverage   54.29%   54.40%   +0.10%     
==========================================
  Files         117      117              
  Lines       10169    10226      +57     
==========================================
+ Hits         5521     5563      +42     
- Misses       4648     4663      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsxiaoys wsxiaoys merged commit abeaa18 into main Apr 9, 2024
6 of 7 checks passed
@wsxiaoys wsxiaoys deleted the event-fix branch April 9, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants