Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(download): Add support for segmented model urls #1735

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Conversation

boxbeam
Copy link
Contributor

@boxbeam boxbeam commented Mar 27, 2024

Fixes TAB-564, closes #1318

@boxbeam boxbeam requested a review from wsxiaoys March 27, 2024 19:43
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 53.33%. Comparing base (be17d8b) to head (2f17e2c).
Report is 5 commits behind head on main.

Files Patch % Lines
crates/tabby-download/src/lib.rs 0.00% 65 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
- Coverage   53.99%   53.33%   -0.66%     
==========================================
  Files         115      115              
  Lines        9784     9779       -5     
==========================================
- Hits         5283     5216      -67     
- Misses       4501     4563      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

crates/tabby-common/src/registry.rs Outdated Show resolved Hide resolved
@boxbeam
Copy link
Contributor Author

boxbeam commented Mar 28, 2024

Tested locally

@wsxiaoys wsxiaoys changed the title feat(download): Add support for segmented models feat(download): Add support for segmented model urls Mar 29, 2024
@wsxiaoys wsxiaoys merged commit e45e509 into main Mar 29, 2024
5 of 7 checks passed
@wsxiaoys wsxiaoys deleted the segmented-models branch March 29, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to deploy segmented GGUF files on the server.
2 participants