feat(ui): interface for the experiment flags #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwayne
force-pushed
the
experiment-flag-ui
branch
from
ce5c52a to
7b13880
Compare
wwayne
commented
Mar 27, 2024
wsxiaoys
reviewed
Mar 27, 2024
There was a problem hiding this comment.
please follow the naming practices:
experiments/components/flag-list.tsx
wsxiaoys
reviewed
Mar 27, 2024
|
Does it make sense to display the status of the chat workers in the ActionBar switcher? |
wsxiaoys
reviewed
Mar 28, 2024
| import FeatureList from './components/feature-list' | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: 'Experimental AI' |
wsxiaoys
reviewed
Mar 28, 2024
Comment on lines
17
to
19
| Enable Quick Action Bar to display a convenient toolbar when you | ||
| select code, offering options to explain the code, add unit tests, | ||
| and more. |
There was a problem hiding this comment.
Suggested change
| Enable Quick Action Bar to display a convenient toolbar when you | |
| select code, offering options to explain the code, add unit tests, | |
| and more. | |
| {quickActionBar.description} |
wsxiaoys
reviewed
Mar 28, 2024
| {!quickActionBar.loading && ( | ||
| <div className="flex items-center space-x-4 rounded-md border p-4"> | ||
| <div className="flex-1 space-y-1"> | ||
| <p className="text-sm font-medium leading-none">Quick Action Bar</p> |
There was a problem hiding this comment.
Suggested change
| <p className="text-sm font-medium leading-none">Quick Action Bar</p> | |
| <p className="text-sm font-medium leading-none">{}</p> |
There was a problem hiding this comment.
use {quickActionBar.title}
wsxiaoys
changed the title
wsxiaoys
reviewed
Mar 28, 2024
Comment on lines
65
to
67
| <SidebarButton href="/experiments"> | ||
| <IconSparkles /> Experimental AI | ||
| </SidebarButton> |
There was a problem hiding this comment.
Suggested change
| <SidebarButton href="/experiments"> | |
| <IconSparkles /> Experimental AI | |
| </SidebarButton> |
Don't display it in side bar, it's developer only page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close TAB-566