Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clients): remove timeout limit for completion requests #1263

Merged
merged 4 commits into from
Jan 22, 2024
Merged

fix(clients): remove timeout limit for completion requests #1263

merged 4 commits into from
Jan 22, 2024

Conversation

icycodes
Copy link
Member

@icycodes icycodes commented Jan 22, 2024 •
edited
Loading

Complete TAB-423

Changes:

  • Removed timeout limit for completion requests.
  • Removed completion.timeout config in the config.toml.
  • Updated the timeout limit for all http requests from 30s to 120s.
  • Updated rules for checking timed-out/slow response time, now no need to wait for 3 samples
    • Slow response time warning: recent requests (at least 1 up to 10 samples) have an average latency > 5s
    • Timed out warning: the percentage of timed out requests in recent requests (at least 1 up to 10 samples) > 50%
    • Mark as healthy again: the latest request was successful and has a latency < 3s
  • Removed notification for timed-out/slow response time, now only the status bar icon shows the warning.

    • If user choose Don't show again, the status bar icon will no longer show the warning

    • VSCode preview, slow response time warning
      Status bar hover:
      Screenshot from 2024-01-22 13-33-54
      Click status bar icon -> show notification:
      Screenshot from 2024-01-22 13-34-06
      Click Detail -> show modal dialog:
      Screenshot from 2024-01-22 13-34-16

    • IntelliJ Plugin preview, slow response time warning
      Status bar hover:
      Screenshot from 2024-01-22 13-37-32
      Click status bar icon -> show menu (includes Check Issue Detail...):
      Screenshot from 2024-01-22 13-37-24
      Click Check Issue Detail... -> show modal dialog:
      Screenshot from 2024-01-22 13-37-51

@icycodes icycodes changed the title Fix clients remove timeout limit fix(clients): remove timeout limit for completion requests Jan 22, 2024
@icycodes icycodes requested a review from wsxiaoys January 22, 2024 05:46
@wsxiaoys wsxiaoys merged commit 84f27ce into TabbyML:main Jan 22, 2024
4 checks passed
boxbeam pushed a commit that referenced this pull request Jan 23, 2024
@icycodes @boxbeam
fix(clients): remove timeout limit for completion requests (#1263)
a89d46f 
* fix(agent): remove completion timeout limit. update slowResponseTime check rules.

* fix(agent): fix response time health check sample window.

* fix(vscode): show only status bar warning icon instead of notification for response time issues.

* fix(intellij): show only status bar warning icon instead of notification for response time issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsxiaoys wsxiaoys Awaiting requested review from wsxiaoys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icycodes @wsxiaoys