fix(ui): prevent submission while typing during isComposing state (#3006

)
TabbyML · Aug 28, 2024 · f2e586c · f2e586c
1 parent bfb25e9
commit f2e586c
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/ee/tabby-ui/components/textarea-search.tsx b/ee/tabby-ui/components/textarea-search.tsx
@@ -89,13 +89,14 @@ export default function TextAreaSearch({
     getPreviouslySelectedRepo()
   }, [])
 
-  const onSearchKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => {
-    if (e.key === 'Enter' && !e.shiftKey) return e.preventDefault()
-  }
-
-  const onSearchKeyUp = (e: React.KeyboardEvent<HTMLTextAreaElement>) => {
-    if (e.key === 'Enter' && !e.shiftKey) {
-      return search()
+  const onSearchKeyDown = (event: React.KeyboardEvent<HTMLTextAreaElement>) => {
+    if (
+      event.key === 'Enter' &&
+      !event.shiftKey &&
+      !event.nativeEvent.isComposing
+    ) {
+      event.preventDefault()
+      search()
     }
   }
 
@@ -172,7 +173,6 @@ export default function TextAreaSearch({
         placeholder={placeholder || 'Ask anything...'}
         maxRows={5}
         onKeyDown={onSearchKeyDown}
-        onKeyUp={onSearchKeyUp}
         onFocus={() => setIsFocus(true)}
         onBlur={() => setIsFocus(false)}
         onChange={e => setValue(e.target.value)}