fix(intellij): fix location for chatView openInEditor. (#3652)

TabbyML · Jan 7, 2025 · 6d46695 · 6d46695
1 parent 14cc15d
commit 6d46695
Showing 1 changed file with 23 additions and 14 deletions.
diff --git a/clients/intellij/src/main/kotlin/com/tabbyml/intellijtabby/chat/ChatBrowser.kt b/clients/intellij/src/main/kotlin/com/tabbyml/intellijtabby/chat/ChatBrowser.kt
@@ -249,25 +249,34 @@ class ChatBrowser(private val project: Project) : JBCefBrowser(
       }
     } ?: return false
 
-    val location = fileLocation.location
-    val position = if (location is Number) {
-      Position(location.toInt() - 1, 0)
-    } else if (location is Position) {
-      location
-    } else if (location is LineRange) {
-      Position(location.start - 1, 0)
-    } else if (location is PositionRange) {
-      location.start
-    } else {
-      null
-    } ?: return false
+    val position = when (val location = fileLocation.location) {
+      is Number -> {
+        Position(location.toInt() - 1, 0)
+      }
+
+      is Position -> {
+        Position(location.line - 1, location.character - 1)
+      }
+
+      is LineRange -> {
+        Position(location.start - 1, 0)
+      }
+
+      is PositionRange -> {
+        Position(location.start.line - 1, location.start.character - 1)
+      }
+
+      else -> {
+        null
+      }
+    }
 
     invokeLater {
       val descriptor = OpenFileDescriptor(
         project,
         virtualFile,
-        position.line.coerceAtLeast(0),
-        position.character.coerceAtLeast(0)
+        position?.line?.coerceAtLeast(0) ?: -1,
+        position?.character?.coerceAtLeast(0) ?: -1,
       )
       fileEditorManager.openTextEditor(descriptor, true)
     }