Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][FEATURE] Replace api key with user and token #4

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

alexanderschnitzler
Copy link

No description provided.

Copy link
Member

@NeoBlack NeoBlack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch looks like a breaking change but it is not marked as breaking.

@alexanderschnitzler
Copy link
Author

What part do you consider breaking?

@NeoBlack
Copy link
Member

the whole patch is breaking.
A public method getHumweeeKey is removed
APP_HUBSPOT_FORM_FRAMEWORK_HUMWEEE_USER is now required without any default.
So an update of the extension will result in a broken system.

maybe I am wrong, but with this patch, a user and token are required instead of the key, which requires a dev/integrator to take care.

@alexanderschnitzler alexanderschnitzler changed the title [FEATURE] Replace api key with user and token [!!!][FEATURE] Replace api key with user and token Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants