[TASK] Introduce beta sitepackage tutorial builder #464
Conversation
linawolf
commented
Nov 21, 2024
linawolf
commented
- Add Class constraints to only use allowed builder-version combinations
- Remove unsupported versions as a drive-by
linawolf
force-pushed
the
task/sitepackage_tutorial
branch
from
f469bb3
to
09a0fe1
Compare
| throw new UnexpectedValueException($constraint, ValidBasePackageVersion::class); | ||
| } | ||
|
|
||
| if ($value->getBasePackage() === 'site_package_tutorial' && $value->getTypo3Version() !== 13.4) { |
There was a problem hiding this comment.
i think we need to check here for versions available in the packages directory and have it generally available as a validator. this one currently only checks for site_package_tutorial and has a fixed version constraint. this would be handy if we provide more variants of for sitepackages.
There was a problem hiding this comment.
This is a first POV which could be enhanced to be more soffisticated down the line...
There was a problem hiding this comment.
will check the validator does not work with the api endpoint currently - will also check how to add general support.
Payload:
{
"base_package": "site_package_tutorial",
"typo3_version": 12.4,
"vendor_name": "string",
"vendor_name_alternative": "string",
"title": "My Sitepackage",
"description": "Project Configuration for Client",
"package_name": "string",
"package_name_alternative": "string",
"extension_key": "string",
"repository_url": "https://github.com/FriendsOfTYPO3/introduction",
"author": {
"name": "J. Doe",
"email": "[email protected]",
"company": "TYPO3",
"homepage": "https://typo3.com"
}
}
There was a problem hiding this comment.
The api end point does not seem to validate whatoever so this seems to be a different issue:
curl -X 'POST' \
'https://get.typo3.org/api/v1/sitepackage/' \
-H 'accept: application/zip' \
-H 'Content-Type: application/json' \
-d '{
"base_package": "apfelbaum",
"typo3_version": 8.7,
"vendor_name": "string",
"vendor_name_alternative": "string",
"title": "My Sitepackage",
"description": "Project Configuration for Client",
"package_name": "string",
"package_name_alternative": "string",
"extension_key": "string",
"repository_url": "https://github.com/FriendsOfTYPO3/introduction",
"author": {
"name": "J. Doe",
"email": "[email protected]",
"company": "TYPO3",
"homepage": "https://typo3.com"
}
}'
just gives you a 500 currently
benjaminkott
force-pushed
the
task/sitepackage_tutorial
branch
2 times, most recently
from
b16bca2
to
ae30c62
Compare
|
Ill have a look |
linawolf
force-pushed
the
task/sitepackage_tutorial
branch
from
ae30c62
to
cd3cf02
Compare
- Add Class constraints to only use allowed builder-version combinations - Remove unsupported versions as a drive-by
linawolf
force-pushed
the
task/sitepackage_tutorial
branch
from
cd3cf02
to
11fbd00
Compare
|
will finish #466 first and rebase this one on top |
