[TASK] Adjust mount point indexing #4195
Conversation
|
Test Reason is probably a bug in |
dkd-friedrich
force-pushed
the
bugfix/main/4160-fix_mountpage_indexing_and_tests
branch
from
ea65d7e
to
08e5ff0
Compare
Yes, I've created an issue and prepared a patch, see https://forge.typo3.org/issues/105376 |
|
I am postponing work on this problem until we receive feedback in https://forge.typo3.org/issues/105376. Our further action depends on whether the patch is adopted. |
dkd-kaehm
force-pushed
the
bugfix/main/4160-fix_mountpage_indexing_and_tests
branch
from
08e5ff0
to
de98a93
Compare
Fixtures of ConnectionManagerTest were not yet updated and included basic configuration that can be provided automatically, this commit cleans the fixtures and enables the automatic provision.
dkd-friedrich
force-pushed
the
bugfix/main/4160-fix_mountpage_indexing_and_tests
branch
from
de98a93
to
da8dbf1
Compare
Mount point indexing and corresponding tests have been adjusted for TYPO3 13. Mount points are supported in general and the mounted pages will be indexed like standard pages. But there is a point to consider: Mounted pages from a pagetree without a site configuration cannot be indexed, in fact TYPO3 currently can't mount a page from a page tree without a site configuration and an exeception occurs. Test procedure in PageIndexerTest has been improved and now uses the PageUriBuilder to build the url to index, instead of building the url in the test itself. Resolves: TYPO3-Solr#4160
Updates of records or pages lead to an SiteNotFoundException if no site is configured. This is caused by the GarbageHandler and/or DataUpdateHandler. This issue is fixed by adding additional checks, skipping the monitoring is save as change are not relevant for solr if no site is present, this includes mount pages as TYPO3 cannot mount pages outside of a configured site. Relates: 4160
dkd-friedrich
force-pushed
the
bugfix/main/4160-fix_mountpage_indexing_and_tests
branch
from
da8dbf1
to
a2fb66f
Compare
Bug is confirmed and patch is merged, fix will be available in upcoming TYPO3 13.4.2 I've completed the updates on this pr, test pipelines using the latest stable TYPO3 version will fail till v13.4.2 is released. We should require v13.4.2 as soon as released. |
Mount point indexing and corresponding tests have been adjusted for
TYPO3 13. Mount points are supported in general and the mounted pages
will be indexed like standard pages.
But there are some points to consider:
config.index_enable = 1is setin the pagetree of the mounted page, as TYPO3 loads the
TypoScript of the mounted page.
This is probably a bug in the TYPO3 core and may change, due to
changes in RootlineUtility->generateRootlineCache() the mount page
pid isn't used any more.
indexed, in fact TYPO3 currently can't mount a page from a page
tree without a site configuration and an exeception occurs.
Test procedure in PageIndexerTest has been improved and now uses
the PageUriBuilder to build the url to index, instead of building
the url in the test itself.
Resolves: #4160
Caution: Do not squash!