Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!![TASK] Configuration option enableRouteEnhancer #3816

Merged
merged 2 commits into from
Oct 10, 2023
Merged

!!![TASK] Configuration option enableRouteEnhancer #3816

merged 2 commits into from
Oct 10, 2023

Conversation

dkd-friedrich
Copy link
Member

What this pr does

  • [BUGFIX] Fix facet route enhancer
  • !!![TASK] Configuration option enableRouteEnhancer

How to test

  1. Configure EXT:solr route enhancer, e.g.:
routeEnhancers:
  solrContentType:
    type: SolrFacetMaskAndCombineEnhancer
    limitToPages:
      - 6
    extensionKey: tx_solr
    routePath: '/contentType/{type}'
    _arguments:
      type: filter-type
    requirements:
      type: '.*'
  1. Check facet links with enabled and disabled option "enableRouteEnhancer"

Fixes: #3810

Caution: PR contains an additional bugfix for the route enhancer in general, do not squash!

@dkd-friedrich
[BUGFIX] Fix facet route enhancer
46555d2 
Renaming of 3 events related to routing caused failures in route
generation in TYPO3 12. This commit replaces the old events
in all occurences missed in the first step and restores the
route enhancer functions.

Relates: TYPO3-Solr#3681
Relates: TYPO3-Solr#3810
@dkd-friedrich
!!![TASK] Configuration option enableRouteEnhancer
0d88011 
EXT:solr offers the possibility to create speaking URLs for Solr
facets, but as this feature requires additional configuration and
costly processing this feature is now disabled by default.

If you've already used the route enhancer you must set option
"enableRouteEnhancer":
$TYPO3_CONF_VARS['EXTENSIONS']['solr']['enableRouteEnhancer']

Resolves: TYPO3-Solr#3810
@dkd-friedrich
Copy link
Member Author

TODO:

  • Add tests
  • ext_conf_template cleanup

dkd-kaehm
dkd-kaehm approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkd-kaehm dkd-kaehm merged commit 529b21a into TYPO3-Solr:main Oct 10, 2023
8 checks passed
@dkd-kaehm dkd-kaehm deleted the task/main/3810-routeenhancer_switch branch October 10, 2023 05:49
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkd-kaehm dkd-kaehm dkd-kaehm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SolrRoutingMiddleware is always in php-slow.log
2 participants
@dkd-friedrich @dkd-kaehm